fix: transfer project not working when target is ALL or ALL_DEFINED or group or subgroup

[long-wan-ep]

Fix for #689.

Adds logic to check for projects being transferred when the target is set to ALL or ALL_DEFINED or a group or subgroup.

[codecov]

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.31%. Comparing base (fe8d11e) to head (1d78b28).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   84.46%   84.31%   -0.15%     
==========================================
  Files          69       69              
  Lines        2749     2774      +25     
==========================================
+ Hits         2322     2339      +17     
- Misses        427      435       +8     

Files	Coverage Δ
gitlabform/lists/projects.py	95.14% <92.10%> (+0.27%)	⬆️

... and 4 files with indirect coverage changes

[amimas]

Thanks @long-wan-ep for the PR. Have couple questions/requests.

Could you please add 2 more test cases that covers the scenario where gitlabform's target is a group or subgroup. It might be an issue for that type of target too, although not sure if this has been caught in the related github issue.

There are some code duplications. For example: checking if it's a project that needs to be transferred, finding project transfer source. Do you think we can reduce the duplication? Maybe move the common code in a function?

[long-wan-ep]

Thanks for the feedback, looking into reducing duplication and adding tests.

[long-wan-ep]

@amimas I've refactored the code a bit to reduce duplication and added 2 more tests for group and subgroup targets. Ready for review again.

[amimas]

Mostly looks good. Left couple more comments to discuss. Also, could you please add couple more tests to capture the scenarios where:

• project doesn't exist and is not configured to be transferred
• project doesn't exist but configured to be transferred and transfer source project is not found

[long-wan-ep]

• project doesn't exist and is not configured to be transferred
• project doesn't exist but configured to be transferred and transfer source project is not found

Added test for "project doesn't exist but configured to be transferred and transfer source project is not found", the test__ALL_DEFINED test should cover the other case.