Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runs container as non-root #719

Merged
merged 1 commit into from Apr 6, 2024

Conversation

lkwg82
Copy link
Contributor

@lkwg82 lkwg82 commented Apr 4, 2024

Runs the container as user different from root for security reasons.

See https://cheatsheetseries.owasp.org/cheatsheets/Docker_Security_Cheat_Sheet.html#rule-2-set-a-user

@lkwg82 lkwg82 had a problem deploying to Integrate Pull Request April 4, 2024 09:29 — with GitHub Actions Failure
@lkwg82 lkwg82 changed the title container runs as non-root runs container as non-root Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.99%. Comparing base (7691014) to head (1860be4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   84.60%   79.99%   -4.62%     
==========================================
  Files          69       69              
  Lines        2774     2774              
==========================================
- Hits         2347     2219     -128     
- Misses        427      555     +128     

see 13 files with indirect coverage changes

Copy link
Member

@gdubicki gdubicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @lkwg82!

@gdubicki gdubicki merged commit 060f40a into gitlabform:main Apr 6, 2024
23 of 25 checks passed
gdubicki added a commit that referenced this pull request Apr 6, 2024
@gdubicki
Copy link
Member

gdubicki commented Apr 6, 2024

Actually this needed a fix to work, see ef57815 @lkwg82.

@gdubicki
Copy link
Member

gdubicki commented Apr 6, 2024

Released in v3.9.3.

gdubicki added a commit to voxpupuli/puppetboard that referenced this pull request Apr 13, 2024
bastelfreak pushed a commit to voxpupuli/puppetboard that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants