fix: dry run failure when project transfer is configured along with other additional configs #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
long-wan-ep
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 84.35% 84.06% -0.29%
==========================================
Files 69 69
Lines 2774 2780 +6
==========================================
- Hits 2340 2337 -3
- Misses 434 443 +9
|
long-wan-ep
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
amimas
reviewed
Apr 11, 2024
There was a problem hiding this comment.
It feels like the logic (setting current project to the value set by transfer_source) will need to be repeated.. wherever the diff is supported. Otherwise this bug will continue to show up. For example: let's say diff is supported for branches or members etc. If the config contains project to be transferred first, when we do dry-run/noop, wouldn't we have the same issue again?
long-wan-ep
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
long-wan-ep
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
requested changes
Apr 11, 2024
long-wan-ep
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
requested changes
Apr 12, 2024
long-wan-ep
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
long-wan-ep
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
approved these changes
Apr 12, 2024
amimas
changed the title
|
Released in v3.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #725.
Project transfer config can fail when run with the
--noopflag, if a processor's_print_diffmethod makes a GitLab API call for the not yet existing project. This PR adds logic to check fortransfer_fromand makes the API call using the correct project path depending on the situation.