Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when running with --noop and --output-file parameter and config contains project to be transferred #729

Merged
merged 4 commits into from Apr 16, 2024

Conversation

long-wan-ep
Copy link
Contributor

Fixes #728.

Update abstract_processor.py to not overwrite project_or_project_and_group when determining if a project is being transferred

@long-wan-ep long-wan-ep requested a deployment to Integrate Pull Request April 16, 2024 19:29 — with GitHub Actions Waiting
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (8e242c9) to head (e5cc975).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   84.74%   85.14%   +0.39%     
==========================================
  Files          69       69              
  Lines        2780     2780              
==========================================
+ Hits         2356     2367      +11     
+ Misses        424      413      -11     
Files Coverage Δ
gitlabform/__init__.py 65.11% <100.00%> (ø)
gitlabform/processors/abstract_processor.py 90.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@long-wan-ep long-wan-ep temporarily deployed to Integrate Pull Request April 16, 2024 20:13 — with GitHub Actions Inactive
@long-wan-ep long-wan-ep requested a deployment to Integrate Pull Request April 16, 2024 22:01 — with GitHub Actions Waiting
@long-wan-ep long-wan-ep temporarily deployed to Integrate Pull Request April 16, 2024 22:03 — with GitHub Actions Inactive
Copy link
Collaborator

@amimas amimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix and tests.

@amimas amimas changed the title fix: project transfer dry-run fails with --output-file flag fix: error when running with --noop and --output-file parameter and config contains project to be transferred Apr 16, 2024
@amimas amimas merged commit f91c9f6 into gitlabform:main Apr 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when output file flag is used with dry-run project transfer
2 participants