build(deps): update to codecov@v4 and use secret for token

[TimKnight-DWP]

Token will be regenerated and rotated post-merge

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.76%. Comparing base (60041fb) to head (55fcd97).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   86.49%   82.76%   -3.74%     
==========================================
  Files          75       75              
  Lines        3162     3162              
==========================================
- Hits         2735     2617     -118     
- Misses        427      545     +118     

Flag	Coverage Δ
integration	79.38% <ø> (-5.54%)	⬇️
unittests	39.81% <ø> (ø)

see 14 files with indirect coverage changes

[gdubicki]

Sorry for a late reply.

I obviously applaud the action upgrade but is token really a secret for public repos? I am sure that we made it plain text in the code on purpose, because the docs recommended so back then.

Now it seems to have changed but if it’s a secret, then it won’t be available in forks. Won’t this break some codecov analysis in the CI/CD for pull requests, @TimKnight-DWP?

[shoddyknight]

Sorry for a late reply.

I obviously applaud the action upgrade but is token really a secret for public repos? I am sure that we made it plain text in the code on purpose, because the docs recommended so back then.

Now it seems to have changed but if it’s a secret, then it won’t be available in forks. Won’t this break some codecov analysis in the CI/CD for pull requests, @TimKnight-DWP?

Good point about the Forks, I hadn't considered that! @gdubicki