Add support for zip archives. #20
Conversation
|
I should have noted, it will not affect current functionality. |
|
Also see Jason his comment in http://feedback.gitlab.com/forums/176466-general/suggestions/4498612-zip-download-format-for-tags @randx Can you give some feedback on this PR? |
| @@ -99,13 +99,14 @@ def discover_default_branch | |||
| # Already packed repo archives stored at | |||
| # app_root/tmp/repositories/project_name/project_name-commit-id.tag.gz | |||
| # | |||
| def archive_repo(ref, storage_path) | |||
| def archive_repo(ref, storage_path, zip = false) | |||
There was a problem hiding this comment.
I am thinking about changing this to accept format (tgz, tar.gz, zip, bz2). In the long term, this will be more flexible. There would then be a case statement below to setup the proper file extension and format and pipe arguments for grit.archive_to_file. If the format is not in the list, it would fallback to tar.gz.
ghost
mentioned this pull request
|
@dosire @randx The GitLab portion of this can be found at gitlabhq/gitlabhq#5891. This one must be merged before the other. |
|
|
||
| extension = ".tar.gz" | ||
| git_archive_format = nil | ||
| pipe_cmd = nil |
There was a problem hiding this comment.
better put these lines under else case.
Additionally, this adds support for bz2 compression and uncompressed tar files. Any unknown format falls back to tar.gz.
|
@randx Updates have been made. I also went ahead and added the |
Add support for zip archives.
|
@jhollingsworth thank you |
ghost
deleted the
|
@jacobvosmaer You are correct. The command should be I will also create a fresh install to develop on to avoid having something like this happen in the future. Sorry for the mistake. |
This adds support for zip archives. This is the first step to getting this suggestion (http://feedback.gitlab.com/forums/176466-general/suggestions/4498612-zip-download-format-for-tags) into GitLab.