Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Fixed JSON encoding error #14

Merged
merged 1 commit into from
Aug 26, 2013
Merged

Fixed JSON encoding error #14

merged 1 commit into from
Aug 26, 2013

Conversation

sugarmo
Copy link
Contributor

@sugarmo sugarmo commented Aug 26, 2013

When git's log contain UTF8 code (e.g. Chinese text), to_json conver it to wrong string with "���"

qq20130826-1

With this fix, encoding will work correctly.

When git's log contain UTF8 code, to_json conver it to wrong string
with ���
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 9c9e91d on sugarmo:master into 4ea9402 on gitlabhq:master.

@sugarmo
Copy link
Contributor Author

sugarmo commented Aug 26, 2013

@randx Take a look please, it's common bug.

dzaporozhets added a commit that referenced this pull request Aug 26, 2013
Fixed JSON encoding error
@dzaporozhets dzaporozhets merged commit bf0ab29 into gitlabhq:master Aug 26, 2013
@dzaporozhets
Copy link
Member

@sugarmo thank you

@Razer6
Copy link
Member

Razer6 commented Aug 26, 2013

@sugarmo Does this fix this encoding issues on the graphs page? eg https://github.com/gitlabhq/gitlabhq/issues/4466 https://github.com/gitlabhq/gitlabhq/issues/4396

@sugarmo
Copy link
Contributor Author

sugarmo commented Aug 26, 2013

I do think it does. It's fixing from the source.

On Tuesday, August 27, 2013, Robert Schilling wrote:

@sugarmo https://github.com/sugarmo Does this fix this encoding issues
on the graphs page? eg gitlabhq/gitlabhq#4466https://github.com/gitlabhq/gitlabhq/issues/4466
gitlabhq/gitlabhq#4396 https://github.com/gitlabhq/gitlabhq/issues/4396


Reply to this email directly or view it on GitHubhttps://github.com//pull/14#issuecomment-23278438
.

Sent from Gmail Mobile

@Razer6
Copy link
Member

Razer6 commented Aug 26, 2013

👍 Then I'll close the other issues

@No1zzz
Copy link

No1zzz commented Aug 27, 2013

I find file here gitlab/vendor/bundle/ruby/1.9/gems/gitlab_git-1.3.0/lib/gitlab_git/log_parser.rb
But there is no lines like in merge req.

@sugarmo
Copy link
Contributor Author

sugarmo commented Aug 27, 2013

@No1zzz We are now using 2.1.1 not 1.3.0, you should update your gems.

@No1zzz
Copy link

No1zzz commented Aug 27, 2013

Ok,ty for reply.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
5 participants