Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Refactor commit and improve code coverage. #2

Merged
merged 2 commits into from May 14, 2013
Merged

Refactor commit and improve code coverage. #2

merged 2 commits into from May 14, 2013

Conversation

splattael
Copy link
Contributor

Define serializable keys as a constant.
This reduces ivar allocation on every commit instance.

Coverage improves:

  • commit_spec.rb: 87.14% -> 98.57%
  • overall: 90.91% -> 92.16%

Peter Suschlik added 2 commits May 14, 2013 16:22
commit_spec.rb: 87.14% -> 98.57%
overall: 90.91% -> 92.16%
@dzaporozhets
Copy link
Member

Nice! thank you

dzaporozhets added a commit that referenced this pull request May 14, 2013
Refactor commit and improve code coverage.
@dzaporozhets dzaporozhets merged commit 3544203 into gitlabhq:master May 14, 2013
@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling e2c8ac7 on splattael:refactor-commit into 2845659 on gitlabhq:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants