This repository has been archived by the owner on May 12, 2018. It is now read-only.
Add new method to Gitlab::Git::Repository #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new convenience method, `#enable_autocrlf`, to the Repository class. The new method sets the `core.autocrlf` config option to true for a repo.
|
Thanks for the @mr-vinn |
|
Cool, this might fix https://gitlab.com/gitlab-org/gitlab-ce/issues/1823 The only thing I am not sure about is whether Rugged/libgit2 respects core.autocrlf internally. We might want to try that first. cc @DouweM |
|
@jacobvosmaer Confirmed to work. I'm merging this, and going through the motions to get this into gitlab-ce and use it there. Edit: Whoops, I was too quick to say it worked. It's not working (yet). I'll continue to look into it. |
DouweM
added a commit
that referenced
this pull request
Jun 20, 2015
Add new method to Gitlab::Git::Repository
|
Superseded by https://gitlab.com/gitlab-org/gitlab_git/merge_requests/29. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new convenience method,
#enable_autocrlf, to the Repository class. The new method sets thecore.autocrlfconfig option to true for a repo. This can be used by GitLab in satellite repos to handle the\r\nline endings that get written when editing via the web interface. This is part of the fix for gitlabhq/gitlabhq#7950.