Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Consider 'ref' when working for graph page #7

Merged
merged 1 commit into from
Sep 20, 2013

Conversation

zzet
Copy link
Contributor

@zzet zzet commented Aug 8, 2013

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 3aca8ff on zzet:patch-2 into 2a252fe on gitlabhq:master.

@MrKeiKun
Copy link

👍

@dzaporozhets
Copy link
Member

Can you rebase please?

@zzet
Copy link
Contributor Author

zzet commented Sep 20, 2013

@randx done

dzaporozhets added a commit that referenced this pull request Sep 20, 2013
Consider 'ref' when working for graph page
@dzaporozhets dzaporozhets merged commit 50d90b9 into gitlabhq:master Sep 20, 2013
@dzaporozhets
Copy link
Member

@zzet thank you

dzaporozhets added a commit that referenced this pull request Nov 19, 2014
Handle invalid submodule

Add better error handling to the submodule processing in `Gitlab::Git::Repository`:

* Return an empty hash from `#submodules` when the specified commit doesn't have a `.gitmodules` file.

* Omit entries from the return value of `#submodules` when the entry in `.gitmodules` has an invalid path.

Fixes #7, gitlab-org/gitlab-ce#714, and gitlab-org/gitlab-ce#763.  Also fixes one of the recent [comments](https://gitlab.com/gitlab-org/gitlab-ce/issues/333#note_367106) from gitlab-org/gitlab-ce#333.

/cc @jacobvosmaer @dzaporozhets

See merge request !14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants