Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'bvl-delete-empty-fork-networks' into 'master'
Delete empty fork networks See merge request gitlab-org/gitlab-ce!15373
- Loading branch information
Showing
7 changed files
with
102 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
title: Clean up empty fork networks | ||
merge_request: 15373 | ||
author: | ||
type: other |
36 changes: 36 additions & 0 deletions
36
db/post_migrate/20171114104051_remove_empty_fork_networks.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
class RemoveEmptyForkNetworks < ActiveRecord::Migration | ||
include Gitlab::Database::MigrationHelpers | ||
|
||
DOWNTIME = false | ||
BATCH_SIZE = 10_000 | ||
|
||
class MigrationForkNetwork < ActiveRecord::Base | ||
include EachBatch | ||
|
||
self.table_name = 'fork_networks' | ||
end | ||
|
||
class MigrationForkNetworkMembers < ActiveRecord::Base | ||
self.table_name = 'fork_network_members' | ||
end | ||
|
||
disable_ddl_transaction! | ||
|
||
def up | ||
say 'Deleting empty ForkNetworks in batches' | ||
|
||
has_members = MigrationForkNetworkMembers | ||
.where('fork_network_members.fork_network_id = fork_networks.id') | ||
.select(1) | ||
MigrationForkNetwork.where('NOT EXISTS (?)', has_members) | ||
.each_batch(of: BATCH_SIZE) do |networks| | ||
deleted = networks.delete_all | ||
|
||
say "Deleted #{deleted} rows in batch" | ||
end | ||
end | ||
|
||
def down | ||
# nothing | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
FactoryGirl.define do | ||
factory :fork_network_member do | ||
association :project | ||
association :fork_network | ||
|
||
forked_from_project { fork_network.root_project } | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
require 'spec_helper' | ||
require Rails.root.join('db', 'post_migrate', '20171114104051_remove_empty_fork_networks.rb') | ||
|
||
describe RemoveEmptyForkNetworks, :migration do | ||
let!(:fork_networks) { table(:fork_networks) } | ||
|
||
let(:deleted_project) { create(:project) } | ||
let!(:empty_network) { create(:fork_network, id: 1, root_project_id: deleted_project.id) } | ||
let!(:other_network) { create(:fork_network, id: 2, root_project_id: create(:project).id) } | ||
|
||
before do | ||
deleted_project.destroy! | ||
end | ||
|
||
it 'deletes only the fork network without members' do | ||
expect(fork_networks.count).to eq(2) | ||
|
||
migrate! | ||
|
||
expect(fork_networks.find_by(id: empty_network.id)).to be_nil | ||
expect(fork_networks.find_by(id: other_network.id)).not_to be_nil | ||
expect(fork_networks.count).to eq(1) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters