Use Hash syntax for LDAP server declaration

gitlabhq · Oct 14, 2014 · 6ce65a3 · 6ce65a3
1 parent 9bf7bfd
commit 6ce65a3
Show file tree

Hide file tree

Showing 7 changed files with 29 additions and 29 deletions.
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb
@@ -19,7 +19,7 @@ def new
     end
 
     if Gitlab.config.ldap.enabled
-      @ldap_servers = Gitlab.config.ldap.servers
+      @ldap_servers = Gitlab::LDAP::Config.servers
     end
 
     super

diff --git a/app/views/devise/sessions/new.html.haml b/app/views/devise/sessions/new.html.haml
@@ -6,13 +6,13 @@
       %ul.nav.nav-tabs
         - @ldap_servers.each_with_index do |server, i|
           %li{class: (:active if i==0)}
-            = link_to server['label'], "#tab-#{server.provider_name}", 'data-toggle' => 'tab'
+            = link_to server['label'], "#tab-#{server['provider_name']}", 'data-toggle' => 'tab'
         %li
           = link_to 'Standard', '#tab-signin', 'data-toggle' => 'tab'
       .tab-content
         - @ldap_servers.each_with_index do |server,i|
-          %div.tab-pane{id: "tab-#{server.provider_name}", class: (:active if i==0)}
-            = render 'devise/sessions/new_ldap', provider: server.provider_name
+          %div.tab-pane{id: "tab-#{server['provider_name']}", class: (:active if i==0)}
+            = render 'devise/sessions/new_ldap', provider: server['provider_name']
         %div#tab-signin.tab-pane
           = render 'devise/sessions/new_base'
 

diff --git a/config/gitlab.yml.example b/config/gitlab.yml.example
@@ -135,18 +135,16 @@ production: &base
   ldap:
     enabled: false
     servers:
-      -
-        ## provider_id
-        #
-        # This identifier is used by GitLab to keep track of which LDAP server each
-        # GitLab user belongs to. Each LDAP server known to GitLab should have a unique
-        # provider_id. This identifier cannot be changed once users from the LDAP server
-        # have started logging in to GitLab.
-        #
-        # Format: one word, using a-z (lower case) and 0-9
-        # Example: 'paris' or 'uswest2'
-
-        provider_id: main
+      ## provider id
+      #
+      # This identifier is used by GitLab to keep track of which LDAP server each
+      # GitLab user belongs to. Each LDAP server known to GitLab should have a unique
+      # provider id. This identifier cannot be changed once users from the LDAP server
+      # have started logging in to GitLab.
+      #
+      # Format: one word, using a-z (lower case) and 0-9
+      # Example: 'paris' or 'uswest2'
+      main:
 
         ## label
         #

diff --git a/config/initializers/1_settings.rb b/config/initializers/1_settings.rb
@@ -62,14 +62,16 @@ def verify_constant(modul, current, default)
   if Settings.ldap['host'].present?
     server = Settings.ldap.except('sync_time')
     server['label'] = 'LDAP'
-    server['provider_id'] = ''
-    Settings.ldap['servers'] = [server]
+    server['provider_name'] = 'ldap'
+    Settings.ldap['servers'] = {
+      'ldap' => server
+    }
   end
 
-  Settings.ldap['servers'].each do |server|
+  Settings.ldap['servers'].each do |key, server|
     server['allow_username_or_email_login'] = false if server['allow_username_or_email_login'].nil?
     server['active_directory'] = true if server['active_directory'].nil?
-    server['provider_name'] = "ldap#{server['provider_id']}".downcase
+    server['provider_name'] ||= "ldap#{key}".downcase
     server['provider_class'] = OmniAuth::Utils.camelize(server['provider_name'])
   end
 end

diff --git a/config/initializers/7_omniauth.rb b/config/initializers/7_omniauth.rb
@@ -1,9 +1,9 @@
 module OmniAuth::Strategies
-  server = Gitlab.config.ldap.servers.first
-  const_set(server.provider_class, Class.new(LDAP))
+  server = Gitlab.config.ldap.servers.values.first
+  const_set(server['provider_class'], Class.new(LDAP))
 end
 
 OmniauthCallbacksController.class_eval do
-  server = Gitlab.config.ldap.servers.first
-  alias_method server.provider_name, :ldap
+  server = Gitlab.config.ldap.servers.values.first
+  alias_method server['provider_name'], :ldap
 end
diff --git a/config/initializers/devise.rb b/config/initializers/devise.rb
@@ -205,14 +205,14 @@
   # end
 
   if Gitlab.config.ldap.enabled
-    Gitlab.config.ldap.servers.each do |server|
+    Gitlab.config.ldap.servers.values.each do |server|
       if server['allow_username_or_email_login']
         email_stripping_proc = ->(name) {name.gsub(/@.*$/,'')}
       else
         email_stripping_proc = ->(name) {name}
       end
 
-      config.omniauth server.provider_name,
+      config.omniauth server['provider_name'],
         host:     server['host'],
         base:     server['base'],
         uid:      server['uid'],

diff --git a/lib/gitlab/ldap/config.rb b/lib/gitlab/ldap/config.rb
@@ -9,11 +9,11 @@ def self.enabled?
       end
 
       def self.servers
-        Gitlab.config.ldap.servers
+        Gitlab.config.ldap.servers.values
       end
 
       def self.providers
-        servers.map &:provider_name
+        servers.map {|server| server['provider_name'] }
       end
 
       def initialize(provider)
@@ -75,7 +75,7 @@ def base_config
       end
 
       def config_for(provider)
-        base_config.servers.find { |server| server.provider_name == provider }
+        base_config.servers.values.find { |server| server['provider_name'] == provider }
       end
 
       def encryption