Skip to content

Commit

Permalink
Accommodate new webhook url format.
Browse files Browse the repository at this point in the history
  • Loading branch information
maxlazio committed Oct 6, 2014
1 parent 216fb6e commit e5998ad
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 5 deletions.
12 changes: 7 additions & 5 deletions app/models/project_services/slack_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@ def execute(push_data)
project_name: project_name
))

credentials = webhook.match(/(\w*).slack.com.*token=(\w*)/)
subdomain = credentials[1]
token = credentials[2]
notifier = Slack::Notifier.new(subdomain, token)
notifier.ping(message.pretext, attachments: message.attachments)
credentials = webhook.match(/(\w*).slack.com.*services\/(.*)/)
if credentials.present?
subdomain = credentials[1]
token = credentials[2].split("token=").last
notifier = Slack::Notifier.new(subdomain, token)
notifier.ping(message.pretext, attachments: message.attachments)
end
end

private
Expand Down
21 changes: 21 additions & 0 deletions spec/models/slack_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,12 @@

describe "Execute" do
let(:slack) { SlackService.new }
let(:slack_service) { SlackService.new }
let(:user) { create(:user) }
let(:project) { create(:project) }
let(:sample_data) { GitPushService.new.sample_data(project, user) }
let(:webhook) { 'https://gitlabhq.slack.com/services/hooks?token=cdIj4r4LfXUOySDUjp0tk3OI' }
let(:new_webhook) { 'https://hooks.gitlabhq.slack.com/services/cdIj4r4LfXUOySDUjp0tk3OI' }
let(:api_url) {
'https://gitlabhq.slack.com/services/hooks/incoming-webhook?token=cdIj4r4LfXUOySDUjp0tk3OI'
}
Expand All @@ -56,5 +58,24 @@

WebMock.should have_requested(:post, api_url).once
end

context 'with new webhook syntax' do
before do
slack_service.stub(
project: project,
project_id: project.id,
service_hook: true,
webhook: new_webhook
)

WebMock.stub_request(:post, api_url)
end

it "should call Slack API" do
slack_service.execute(sample_data)

WebMock.should have_requested(:post, api_url).once
end
end
end
end

0 comments on commit e5998ad

Please sign in to comment.