Skip to content

Commit

Permalink
Enable Style/UnneededCapitalW Rubocop cop
Browse files Browse the repository at this point in the history
  • Loading branch information
grzesiek committed Jun 30, 2016
1 parent 2efee5f commit efd70c1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .rubocop.yml
Expand Up @@ -681,7 +681,7 @@ Style/UnlessElse:

# Checks for %W when interpolation is not needed.
Style/UnneededCapitalW:
Enabled: false
Enabled: true

# TODO: Enable UnneededInterpolation Cop.
# Checks for strings that are just an interpolated expression.
Expand Down
2 changes: 1 addition & 1 deletion lib/gitlab/key_fingerprint.rb
Expand Up @@ -39,7 +39,7 @@ def explicit_fingerprint_algorithm?
# OpenSSH 6.8 introduces a new default output format for fingerprints.
# Check the version and decide which command to use.

version_output, version_status = popen(%W(ssh -V))
version_output, version_status = popen(%w(ssh -V))
return false unless version_status.zero?

version_matches = version_output.match(/OpenSSH_(?<major>\d+)\.(?<minor>\d+)/)
Expand Down
6 changes: 3 additions & 3 deletions spec/lib/gitlab/popen_spec.rb
Expand Up @@ -10,7 +10,7 @@

context 'zero status' do
before do
@output, @status = @klass.new.popen(%W(ls), path)
@output, @status = @klass.new.popen(%w(ls), path)
end

it { expect(@status).to be_zero }
Expand All @@ -19,7 +19,7 @@

context 'non-zero status' do
before do
@output, @status = @klass.new.popen(%W(cat NOTHING), path)
@output, @status = @klass.new.popen(%w(cat NOTHING), path)
end

it { expect(@status).to eq(1) }
Expand All @@ -34,7 +34,7 @@

context 'without a directory argument' do
before do
@output, @status = @klass.new.popen(%W(ls))
@output, @status = @klass.new.popen(%w(ls))
end

it { expect(@status).to be_zero }
Expand Down

0 comments on commit efd70c1

Please sign in to comment.