Debian package files #1094
Debian package files #1094
Conversation
|
+1 nice. this should simplify deployment on debian machines quite a bit |
| proxy_redirect off; | ||
| # you need to change this to "https", if you set "ssl" directive to "on" | ||
| proxy_set_header X-FORWARDED_PROTO http; | ||
| proxy_set_header Host gitlab.local.host:80; |
There was a problem hiding this comment.
If you set up the host to use https you should also change the host port to 443. Also consider adding a second server block to handle http to https redirection :)
There was a problem hiding this comment.
Sorry about the delay to reply, but the commit added to my master branch should fix it, ssl and non-ssl vhost with redirect rule for nginx.
|
+1 |
|
really much want this for my nginx riding on a little squeezy debian :) |
|
This wins. Thank you! |
|
👍 but I'm not sure if it should be included in the Gitlab repo. /cc @vsizov |
|
@NARKOZ why not? |
|
nice one! +1 |
| Section: ruby | ||
| Priority: extra | ||
| Maintainer: root <root@squeezao> | ||
| Build-Depends: debhelper, libicu-dev, ruby1.9.1-dev, libmysqlclient-dev, libsqlite3-dev |
There was a problem hiding this comment.
Should also include bundler as a build dependency.
There was a problem hiding this comment.
AFAIK Debian doesn't have a bundler package by default.
There was a problem hiding this comment.
Oh, sorry, I'm on Debian Sid and missed that it isn't on Squeeze. I guess the situation isn't as cut-and-dry then. I don't know much about packaging practices. Is there some clean way of resolving this?
There was a problem hiding this comment.
Maybe we should add the dependency as you said and assume an installed version from bundler as a backport. I can't see a better solution.
@rsampaio, ideas?
There was a problem hiding this comment.
Well, I think the best we can do to support multiple debian releases is to add a Recommend line on this control file so via apt-get it will recommend the libbundle-ruby during the install, we use a backported libbundle-ruby1.9.1 internaly here so forcing this package as a dep will work but definitively we should not force a dependency when it does not exist in that release.
Let me know what you think.
| case "$1" in | ||
| configure) | ||
|
|
||
| git_exists=$(grep -w git /etc/passwd | wc -l) |
There was a problem hiding this comment.
The simplest portable way to check that an user exists is to chown something.
Like this:
makedir /tmp/gitlab root:root 700
chgrp git /tmp/gitlab 2>/dev/null ||
addgroup --system gitl
chown git /tmp/gitlab 2>/dev/null ||
adduser --system --home /home/git --shell /bin/sh --gecos 'git version control' --ingroup git --disabled-password gitThere was a problem hiding this comment.
good catch, changed my previous try to this one.
|
Thanks for the comments @Gittex, tried to fix everything so should be ok now. |
|
@PotHix it's for gitlab source, not for binary or installation packages. @rsampaio can you submit it to gitlabhq/gitlab-recipes? It has more chances to be merged there. Thanks. |
|
@NARKOZ well ok I can do it, will help who would like to deploy via a proper package but I strong believe that it should be part of the source like any other distribute-able software including the ones that gitlab rely on. Also it is just the "debian" directory and nothing else was touched. |
|
Since we officially support deb-based distros I'll better ping @randx :)
You added CAS authentication. That's why Travis build fails. |
|
@NARKOZ ops that was a mistake, this was merged from locaweb/gitlabhq and CAS is only meant to be used internally and not part of this pull request, gonna fix this. |
Added files to create a proper .deb file as follows:
git clone repository/gitlabhq.git
cd gitlabhq
dpkg-buildpackage
To install the package and deps use:
dpkg -i ../gitlabhq_*.deb
apt-get -f install
Advantages over debian_ubuntu.sh:
Thanks for the great project, much simpler and elegant than gitorious.
Rodrigo.