Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dark code preview background when displaying long lines #2211

Merged
merged 1 commit into from Dec 20, 2012
Merged

fix dark code preview background when displaying long lines #2211

merged 1 commit into from Dec 20, 2012

Conversation

jojosch
Copy link
Contributor

@jojosch jojosch commented Dec 7, 2012

If you are using the dark code preview
And a file has a long line
And you scroll to the right
The following display-error occurs:

Tested in Firefox, Chrome.
Internet Explorer 8-10 ( :) )
IE9 no background before/after.
Opera had no issue before and after the change.

before

Snippets:
Snippet error

File Source
File Source error

after

Snippets:
Snippet error

dzaporozhets added a commit that referenced this pull request Dec 20, 2012
fix dark code preview background when displaying long lines
@dzaporozhets dzaporozhets merged commit 9bc315b into gitlabhq:master Dec 20, 2012
@dzaporozhets
Copy link
Member

thank you

@jojosch jojosch deleted the fix-dark-code-preview branch December 20, 2012 16:01
@yuters
Copy link
Contributor

yuters commented Dec 21, 2012

The float:left; is causing problems elsewhere :

Screen Shot 2012-12-21 at 3 17 06 PM

@dzaporozhets
Copy link
Member

@yuters thank you. it will be fixed before 4.0

dzaporozhets pushed a commit that referenced this pull request Apr 10, 2015
This option defaults to true in RedCarpet 3.2.0, but we handle
sanitization later in the process with html-pipeline.

Closes #2211
dzaporozhets added a commit that referenced this pull request Apr 10, 2015
Update redcarpet to 3.2.3

Closes #2211

See merge request !1756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants