OS X support for gitlab:check rake tasks #2890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gitlab:check
(and other:check
) rake tasks currently fail on OS X due to thegid_for
method in TaskHelpers.rake manually parsing the /etc/group file:While the
/etc/group
file exists on OS X it's only used for system services, with all user-created users and groups using Directory Services instead.This simple pull request replaces the manual parsing of
/etc/group
with an equivalent call to the platform-independentEtc
class from the standard library.All tests continue to pass after this amend.