Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better RVM & Passenger Integration #428

Closed
wants to merge 2 commits into from
Closed

Better RVM & Passenger Integration #428

wants to merge 2 commits into from

Conversation

RLovelett
Copy link
Contributor

Allows Passenger to read and use an RVM .rvmrc file if it exists in the directory.

@robbkidd
Copy link
Contributor

robbkidd commented Mar 3, 2012

+1 We've added this to our install as well. Content comes straight from RVM docs for Passenger.

@ariejan
Copy link
Contributor

ariejan commented Mar 28, 2012

This is great if you use passenger and rvm. The installation guide sets you up with unicorn and nginx.

It'd be great to add this to the wiki for those who need it.

Also, Passenger 3 has awesome rvm/multi-rubies support: http://blog.phusion.nl/2010/09/21/phusion-passenger-running-multiple-ruby-versions/

@ariejan ariejan closed this Mar 28, 2012
@robbkidd
Copy link
Contributor

Thanks for your response, @ariejan.

I do not believe this change is specific to Passenger; I believe that it is needed for RVM.

We are using nginx and Unicorn. We followed the installation guide except that we chose to manage our Ruby install with RVM instead of downloading and installing directly from source. We had to make the change described in this pull request to our install even though we are not using Apache or Passenger.

This would be a nice thing to include in the code base for users who opt to use RVM. It should be safe to include for those users who follow the install instructions directly. But if GitLabHQ does not wish to support RVM out of the box, the wiki--as you say--would be a great place to document this.

@brodock
Copy link
Member

brodock commented Apr 7, 2012

+1 to get this merged...

also:

I want to point to one more thing that can be changed that will benefit thous using RVM without any side effect:

Instead of suggesting to run commands as:

sudo -u gitlab bundle exec ...

It's better to run it as:

sudo su - gitlab bash -c 'cd gitlab;bundle exec ...'

The reason for this is that RVM depends on scripts that are loaded during "login", and will not be available otherway.

And finally at the init script, change:

sudo -u gitlab sh -c "$CD_TO_APP_DIR > /dev/null 2>&1 && $START_DAEMON_PROCESS && $START_RESQUE_PROCESS"

to:

sudo su - gitlab bash -c "$CD_TO_APP_DIR > /dev/null 2>&1 && $START_DAEMON_PROCESS && $START_RESQUE_PROCESS"

@riyad
Copy link
Contributor

riyad commented Apr 8, 2012

+1

allysonbarros added a commit to allysonbarros/gitlabhq that referenced this pull request Jul 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants