Add time ago tooltips to show actual date/time #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up admin dashboad tooltips Clean up admin dashboad tooltips Clean up admin dashboad tooltips Add helper method change to use app helper Modify tooltips to use new helper Convert remaining times Adjust one tooltip
|
Looks awesome, what do you think @randx ? |
dzaporozhets
added a commit
that referenced
this pull request
Dec 16, 2013
Add time ago tooltips to show actual date/time
|
@dosire looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the feature as requested in http://feedback.gitlab.com/forums/176466-general/suggestions/4910071-gitlab-should-show-yesterday-and-actual-dates-in
Each tooltip was visually inspected to make sure it looked good in its context. Most tooltips appear above the text. In a few cases it looked better to put the tooltip below the text.
Dashboard tooltip example:
Examples where the tooltip appears below the text:
Project last activity - to avoid covering the project name
Comments - the top tooltip would appear behind the previous comment
Merge requests - to avoid covering merge request details "BRANCH > BRANCH" or "MERGED"
Please let me know if you would like additional screenshots.