Fix for copy-pasting formatted text to markdown area

[erbunao]

We (@nmcalabroso) fixed the bug for pasting a formatted text to the markdown area. This PR is a fix for #7032. Hoping for the feedbacks.

[erbunao]

@randx @dosire This would be the fix for the clipboard bug :)

[jvanbaarsen]

@randx Looks good

[erbunao]

@jvanbaarsen hope there's no more hidden bugs.

[dzaporozhets]

@erbunao I am a bit confused. We reverted #7032 because it breaks copy-paste. What do this fix do then?

[erbunao]

@randx when I last checked our feature, it cannot copy formatted text, only the image and a plain text. So this fix is for fully supporting all types of text. The reason why our last PR can't copy a formatted text is because we override the printing of text to the text area but the copy paste function is working as is. But for this fix, we changed our approach to just paste any kind of text to the text area when it is not an image. Basically, it can now just copy paste literally any text just like any copy paste function. I hope this clears things out :)

[dosire]

@randx So this is #7032 with a fix for the problem.

[dzaporozhets]

@dosire ok thanks for explaining

[dosire]

@randx Thanks for merging.

@erbunao Thanks for fixing, it is great that you contribute awesome features and provide fixes for them as well.

[sanand0]

@erbunao I tried this on Windows 8.1 + Chrome 36 via the Gitlab Omnibus 7.1 package. The following did not work:

1. Copying a file from File Explorer and pasting it into a new issue description. No file was uploaded, nor was there a console error.
2. Copying formatted HTML from this page (with and without images) and pasting it into a new issue description. The plain text was pasted, but no image was uploaded, nor a console error.

Am I doing something wrong?

[dosire]

@sanand0 I don't know, but please open a new issue referencing this one.