Hotfix note mail with notification #9938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how complex it would be, but is it possible to add a test for this case? |
|
Add a test for this case. |
SentNotification need use `record_note` method to save right noteable
DouweM
added a commit
that referenced
this pull request
Jan 4, 2016
…tion Hotfix note mail with notification
|
cc @tsigo This should go in an 8.3 patch release. |
|
@Razer6 Whoops, didn't verify the target branch. |
|
Opened https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2288 to pick into |
DouweM
added a commit
that referenced
this pull request
Jan 5, 2016
…cation Hotfix note mail with notification
DouweM
pushed a commit
that referenced
this pull request
Jan 5, 2016
Merge pull request GH-9938 from huacnlee/hotfix/note_mail_with_notification Hotfix note mail with notification See merge request !2288
dzaporozhets
pushed a commit
that referenced
this pull request
Jan 14, 2016
* master: (75 commits) Fix grammar Clarify the key generation step Remove misleading `ssh-dsa` markdown fixes markdown fixes Add `AbuseReport#notify` Make AbuseReportMailer responsible for knowing if it should deliver Redirect back to user profile page after abuse report Redesign the AbuseReports index Don't notify users twice if they are both project watchers and subscribers Restructure logo JS to use `setInterval` Decrease the logo sweep delay Correct the logo ID names Update CHANGELOG Merge pull request GH-9938 from huacnlee/hotfix/note_mail_with_notification Remove jquery.blockUI.js plugin rempves tests for "you have master access" text Revert "Merge branch 'rs-remove-jquery-blockui' into 'master' " removes footer message about access to project remove public field from namespace and refactoring ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I found some error log:
Email can not be processed: undefined method `note_note_email' for Notify:ClassWhen I reply a Issue comment by Email reply, It will create a new Note into database but not relation with the Issue.
In current 8-3-stable (even in master version),
Emails::NotesinvokedSentNotification.record, that will store a badnoteablevalue.See this file: https://github.com/gitlabhq/gitlabhq/blob/8-0-stable/app/mailers/emails/notes.rb#L46
@yorickpeterse