Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared_runners_enabled argument to gitlab_project resource #134

Merged
merged 6 commits into from May 17, 2019
Merged

Add shared_runners_enabled argument to gitlab_project resource #134

merged 6 commits into from May 17, 2019

Conversation

iAnomaly
Copy link
Contributor

No description provided.

Konstantin Chugalinskiy and others added 2 commits March 14, 2019 16:03
…bled check. Use GitLab API documentation description of shared_runners_enabled.
@iAnomaly
Copy link
Contributor Author

@jorcau @roidelapluie, this replaces #104 with the requested missing tests. Please note that tests have been failing on master since @roidelapluie merged #132 6 days ago. This PR does not add any new failures.

Thanks!

@roidelapluie roidelapluie merged commit 82886a6 into gitlabhq:master May 17, 2019
@roidelapluie
Copy link
Collaborator

@iAnomaly this is breaking tests

@iAnomaly
Copy link
Contributor Author

Hey @roidelapluie. As I pointed out in my previous comment, these tests have been failing since you merged #132; 8 days before you merged my code. Specifically, commit hashicorp@c95dfb0 is when the build stopped passing.

You can compare the test results between the two and see it is the same failure:

  1. Build of hashicorp@c95dfb0 from merge Cleans up "project" resource schema and testing framework #132: https://travis-ci.org/terraform-providers/terraform-provider-gitlab/jobs/530438424
  2. Build of hashicorp@82886a6 from merge of my pull request Add shared_runners_enabled argument to gitlab_project resource #134: https://travis-ci.org/terraform-providers/terraform-provider-gitlab/jobs/533726463

Specifically, the failure is from line 539 of the build log:

--- FAIL: TestAccGitlabProject_basic (6.03s)
testing.go:568: Step 1 error: Check failed: Check 2/2 error: 1 error occurred:
* Check 19/22 error: attribute tags expected "&{F:0xf04970 m:map[4151227546:tag1 1852302624:tag2] once:{m:{state:0 sema:0} done:1}}" received "&{F:0xf04970 m:map[1852302624:tag2 4151227546:tag1] once:{m:{state:0 sema:0} done:1}}"

Does that make sense? Let me know if I am misunderstanding you.

P.S. Sorry for not squashing my commits before you merged. I thought GitHub would allow you to do that automatically at merge time. Alas, I've become too comfortable with GitLab.

@roidelapluie
Copy link
Collaborator

Github allows me to do it but I dont like it.

I changed the value to "computed".

@roidelapluie
Copy link
Collaborator

(there was a failing test because of this .. in addition to the other issue)

@iAnomaly iAnomaly deleted the add-shared-runners-enabled branch May 28, 2019 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants