-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shared_runners_enabled argument to gitlab_project resource #134
Add shared_runners_enabled argument to gitlab_project resource #134
Conversation
…bled check. Use GitLab API documentation description of shared_runners_enabled.
@jorcau @roidelapluie, this replaces #104 with the requested missing tests. Please note that tests have been failing on master since @roidelapluie merged #132 6 days ago. This PR does not add any new failures. Thanks! |
@iAnomaly this is breaking tests |
Hey @roidelapluie. As I pointed out in my previous comment, these tests have been failing since you merged #132; 8 days before you merged my code. Specifically, commit hashicorp@c95dfb0 is when the build stopped passing. You can compare the test results between the two and see it is the same failure:
Specifically, the failure is from line 539 of the build log:
Does that make sense? Let me know if I am misunderstanding you. P.S. Sorry for not squashing my commits before you merged. I thought GitHub would allow you to do that automatically at merge time. Alas, I've become too comfortable with GitLab. |
Github allows me to do it but I dont like it. I changed the value to "computed". |
(there was a failing test because of this .. in addition to the other issue) |
No description provided.