-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add management_project_id for Group and Project Clusters #301
Add management_project_id for Group and Project Clusters #301
Conversation
Moving to draft until GitLab 12.10 is released and tests will pass. |
Tests passing on gitlab.com version
|
Ready for first review. Tests passing. |
@roidelapluie wondering if you could take a look at this. It's blocking another project. Thanks! |
@ringods could you please review this? |
@magic7s if you could rebase this PR and squash some of your commits for a cleaner history, I'll merge immediately after that. You will also notice that the EE tests will be skipped instead of fail after the rebase, which is more clear as an input for merging. 😉 |
64b54c4
to
7ef503b
Compare
7ef503b
to
8b11b75
Compare
Failing test is related to #319. |
Thanks @ringods ! I thought PRs would squash on merge. |
Now we just need a new |
@magic7s Github as an option to squash on merge but I usually choose not to do that. It is your work, so I rather let you choose how much commits you leave in the PR and the commit comments. |
Released in v2.9.0 |
…roj-id Add management_project_id for Group and Project Clusters
Adds
management_project_id
as an option to Group and Project Clusters.Requires GitLab 12.10
Option Documentation: https://docs.gitlab.com/ee/api/group_clusters.html#add-existing-cluster-to-group