Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource for pipelines email integration #375

Merged
merged 4 commits into from Sep 10, 2020

Conversation

jeremad
Copy link
Contributor

@jeremad jeremad commented Aug 6, 2020

Closes #374

@jeremad jeremad force-pushed the jrm/pipeline_emails branch 3 times, most recently from aedb367 to 9f2f914 Compare August 6, 2020 11:34
@ghost ghost added the dependencies label Aug 6, 2020
@jeremad jeremad changed the title Add resource for pipelines email integration WIP: Add resource for pipelines email integration Aug 6, 2020
@jeremad
Copy link
Contributor Author

jeremad commented Aug 6, 2020

needs: xanzy/go-gitlab#903

@jeremad jeremad force-pushed the jrm/pipeline_emails branch 4 times, most recently from 69d61f8 to d004d47 Compare August 6, 2020 14:22
@ghost ghost added size/XXL and removed size/XL labels Aug 6, 2020
@jeremad jeremad changed the title WIP: Add resource for pipelines email integration Add resource for pipelines email integration Aug 6, 2020
@jeremad jeremad force-pushed the jrm/pipeline_emails branch 4 times, most recently from 08621f7 to a0e9bfa Compare August 8, 2020 00:08
@ghost ghost added size/XL and removed size/XXL labels Aug 8, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@jeremad jeremad force-pushed the jrm/pipeline_emails branch 2 times, most recently from cfc3ac6 to fc72ab2 Compare August 8, 2020 21:52
@armsnyder
Copy link
Collaborator

In case you didn't see my reply about the importer. (It was on a resolved thread.) https://github.com/terraform-providers/terraform-provider-gitlab/pull/375#discussion_r467501760

@jeremad jeremad force-pushed the jrm/pipeline_emails branch 3 times, most recently from f652f02 to 362e029 Compare August 9, 2020 09:16
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work on this!

@jeremad
Copy link
Contributor Author

jeremad commented Aug 9, 2020

Thank you for helping me with this!

@jeremad
Copy link
Contributor Author

jeremad commented Aug 19, 2020

Any more reviewer? :)

@jeremad
Copy link
Contributor Author

jeremad commented Sep 4, 2020

@nicholasklick ? 👼

@armsnyder
Copy link
Collaborator

@nicholasklick This one should ready to merge.

@armsnyder armsnyder merged commit a2c27f5 into gitlabhq:master Sep 10, 2020
@jeremad jeremad deleted the jrm/pipeline_emails branch September 10, 2020 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants