Allow disable/enable packages repository #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremad
changed the title
|
There is a temp commit waiting for xanzy/go-gitlab#938 to be released. |
jeremad
force-pushed
the
jrm/disable_packages
branch
from
3477cba
to
0efeaf7
Compare
jeremad
changed the title
jeremad
force-pushed
the
jrm/disable_packages
branch
2 times, most recently
from
9117b38
to
705227d
Compare
|
ready for review @armsnyder |
armsnyder
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
lgtm! @roidelapluie Do you have a way that you usually verify go.mod changes? I saw you mention running go mod vendor in another PR.
|
I did run go mod vendor! but you're right this should be automated somehow |
added 2 commits
September 18, 2020 11:51
jeremad
force-pushed
the
jrm/disable_packages
branch
from
705227d
to
f9c5e5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GitLab 13.3 the packages feature is generally available.
This PR creates an argument
packages_enabledbased on the GitLab API field of the same name to control the activation of this feature.