Update project shared_with_groups option: change type to TypeSet
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Acceptance tests results: |
|
@jorcau how does it behave on existing states? No weird behavior? |
pdecat
suggested changes
Feb 7, 2019
jorcau
force-pushed
the
fix_project_shared-with-groups
branch
from
b8a5d84
to
e5c8d95
Compare
pdecat
suggested changes
Feb 7, 2019
gitlab/resource_gitlab_project.go
Outdated
| if v, ok := d.GetOk("shared_with_groups"); ok { | ||
| options := expandSharedWithGroupsOptions(v.([]interface{})) | ||
| if _, ok := d.GetOk("shared_with_groups"); ok { | ||
| options := expandSharedWithGroupsOptions(d) |
There was a problem hiding this comment.
I did not mean to pass d but v 😕
pdecat
reviewed
Feb 7, 2019
gitlab/resource_gitlab_project.go
Outdated
| @@ -298,10 +298,11 @@ func resourceGitlabProjectDelete(d *schema.ResourceData, meta interface{}) error | |||
| return nil | |||
| } | |||
|
|
|||
| func expandSharedWithGroupsOptions(d []interface{}) []*gitlab.ShareWithGroupOptions { | |||
| func expandSharedWithGroupsOptions(d *schema.ResourceData) []*gitlab.ShareWithGroupOptions { | |||
| v := d.Get("shared_with_groups").(*schema.Set).List() | |||
There was a problem hiding this comment.
The d.Get("shared_with_groups") part should have stayed outside.
jorcau
force-pushed
the
fix_project_shared-with-groups
branch
from
e5c8d95
to
1a159c2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a small fix for the shared_with_groups option in the project resource.
This makes
shared_with_groupsa TypeSet instead of TypeList in order to discard group list order and improve the plan.