Implement gitlab service slack

[jorcau]

Hi,

Here is a new proposal for Slack Integration implementation. It reuses work started on #65. I've talked with @hypnoglow about doing another PR so I guess we could close #65 for this one.

It includes documentation and acceptance tests:

➜ make testacc TEST=./gitlab TESTARGS='-run=TestAccGitlabServiceSlack_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./gitlab -v -run=TestAccGitlabServiceSlack_* -timeout 120m
=== RUN   TestAccGitlabServiceSlack_basic
--- PASS: TestAccGitlabServiceSlack_basic (8.23s)
=== RUN   TestAccGitlabServiceSlack_import
--- PASS: TestAccGitlabServiceSlack_import (6.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-gitlab/gitlab	15.209s

Thanks,

[roidelapluie]

FYI now the Acc tests are run in travis too.

[roidelapluie]

Can you please add an ACC test with default values? Current tests are great but too explicit. I would like another, minimalist one.

[jorcau]

FYI now the Acc tests are run in travis too.

This is awesome!

I added a test with only required fields set as you asked.

[roidelapluie]

shouldnt we fetch the service at this point from gitlab?

[jorcau]

Not sure what you mean here.

From what I understand, the resourceGitlabServiceSlackImportState function should just define the ID or necessary parameters so the READ function can then be called to actually fetch the resource's details.

[rsrchboy]

@roidelapluie Are there any blockers to merging this?

[jorcau]

Hi @roidelapluie, do you have time to review & merge this anytime soon? Thanks!