Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Slack token regexes #1161

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Update Slack token regexes #1161

merged 1 commit into from
Jun 15, 2023

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Apr 24, 2023 •
edited
Loading

Description:

This PR attempts to expand the detection rules to better capture the various Slack token patterns, both new and old.

This fixes #1150.

TODO:

  • Current tokens
    • Match bot tokens
    • Match user tokens
    • Match App-level tokens
    • Match Configuration tokens
  • Legacy tokens
    • Match legacy bot tokens
    • Match legacy workspace tokens
    • Match legacy tokens
  • Webhook URL

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@rgmz rgmz force-pushed the feat/expand-slack-patters branch 2 times, most recently from d5f2a89 to 9f30735 Compare April 24, 2023 21:52
@zricethezav
Copy link
Collaborator

@rgmz is this still a draft?

@rgmz

This comment was marked as outdated.

Sign in to view
@rgmz rgmz force-pushed the feat/expand-slack-patters branch 2 times, most recently from 0e07b67 to 0c91e8b Compare June 14, 2023 19:34
@rgmz rgmz marked this pull request as ready for review June 14, 2023 19:35
@rgmz rgmz changed the title WIP: Update Slack token regexes Update Slack token regexes Jun 14, 2023
@rgmz rgmz force-pushed the feat/expand-slack-patters branch from 0c91e8b to 7ef2417 Compare June 14, 2023 19:45
@rgmz
Copy link
Contributor Author

rgmz commented Jun 14, 2023

@rgmz is this still a draft?

@zricethezav It should be good to go now.

@rgmz rgmz force-pushed the feat/expand-slack-patters branch 7 times, most recently from f4b8012 to b8fe05a Compare June 14, 2023 23:23
@rgmz rgmz force-pushed the feat/expand-slack-patters branch from b8fe05a to f3d565f Compare June 14, 2023 23:25
@zricethezav
Copy link
Collaborator

Looks great! Amazing work as always @rgmz

@zricethezav zricethezav merged commit 463d246 into gitleaks:master Jun 15, 2023
1 check passed
@rgmz rgmz deleted the feat/expand-slack-patters branch August 16, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve slack-access-token pattern.
2 participants
@rgmz @zricethezav