Remove IAM identifiers for non-credential resources in the aws-access-token rule #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only detects: AWS STS service bearer token Context-specific credential Access key Temporary (AWS STS) access key IDs use this prefix, but are unique only in combination with the secret access key and the session token.
|
Hey @kieran-smith-itv, thanks for the PR. These changes make sense to me |
quotengrote
pushed a commit
to quotengrote/miniflux-filter
that referenced
this pull request
Feb 1, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [zricethezav/gitleaks](https://github.com/gitleaks/gitleaks) | patch | `v8.18.1` -> `v8.18.2` | --- > ⚠ **Warning** > > Some dependencies could not be looked up. Check the warning logs for more information. --- ### Release Notes <details> <summary>gitleaks/gitleaks (zricethezav/gitleaks)</summary> ### [`v8.18.2`](https://github.com/gitleaks/gitleaks/releases/tag/v8.18.2) [Compare Source](gitleaks/gitleaks@v8.18.1...v8.18.2) #### Changelog - [`ac4b514`](gitleaks/gitleaks@ac4b514) removed gitleaks user from Dockerfile ([#​1313](gitleaks/gitleaks#1313)) - [`76c9e31`](gitleaks/gitleaks@76c9e31) Remove IAM identifiers for non-credential resources in the aws-access-token rule ([#​1307](gitleaks/gitleaks#1307)) - [`afe046b`](gitleaks/gitleaks@afe046b) Update stripe rule to not alert on publishable keys ([#​1320](gitleaks/gitleaks#1320)) - [`8b8920d`](gitleaks/gitleaks@8b8920d) --max-target-megabytes flag now supported for --no-git flag as well ([#​1330](gitleaks/gitleaks#1330)) - [`a59289c`](gitleaks/gitleaks@a59289c) add pre-commit hook gitleaks-system ([#​1225](gitleaks/gitleaks#1225)) - [`870194b`](gitleaks/gitleaks@870194b) fix errors when using protect and an external git diff tool ([#​1318](gitleaks/gitleaks#1318)) - [`179c607`](gitleaks/gitleaks@179c607) rename filesystem to directory ([#​1317](gitleaks/gitleaks#1317)) - [`8de8938`](gitleaks/gitleaks@8de8938) Enhance Secret Descriptions ([#​1300](gitleaks/gitleaks#1300)) - [`ca7aa14`](gitleaks/gitleaks@ca7aa14) Small refactor `detect` and `sources` ([#​1297](gitleaks/gitleaks#1297)) - [`01e60c8`](gitleaks/gitleaks@01e60c8) chore(config): refactor to go generate; simplify configRules init ([#​1295](gitleaks/gitleaks#1295)) - [`54f5f04`](gitleaks/gitleaks@54f5f04) forgot symlinks - [`221d5c4`](gitleaks/gitleaks@221d5c4) pretty apparent 'protect' and 'detect' should be merged into one command ([#​1294](gitleaks/gitleaks#1294)) - [`128b50f`](gitleaks/gitleaks@128b50f) style: sort the stopwords ([#​1289](gitleaks/gitleaks#1289)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE2NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Reviewed-on: https://git.mgrote.net/container-images/miniflux-filter/pulls/17 Co-authored-by: Renovate Bot <renovate@mgrote.net> Co-committed-by: Renovate Bot <renovate@mgrote.net>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The purpose of this PR is to reduce the number of False Positive detections by the aws-access-token. This PR addresses issue: #1049
The regex for aws-access-token has been updated to only catch:
The following unique IDs are now ignored:
Checklist: