Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default twitter rules #614

Commits on Aug 30, 2021

  1. Fix default twitter rules

    Regexps for default Twitter rules ("Twitter Secret Key" and "Twitter Client
    ID") have a small flaw that make the default configuration vulnerable to
    some false-positives.
    
    I believe these rules should detect the cases like (SOME_CLIENT_ID should
    be longer):
    ```
    "twitter_client_id": "SOME_CLIENT_ID"
    ```
    
    However, currently the twitter rules also detect the false positives for the
    cases like:
    ```
    someObj := twitter.NewObjectWithALongName()
    config.Twitter.DomainAccessToken
    ```
    
    I'm trying to address this issue the similar way it's done for facebook client
    ids and AWS secret keys, where the secret is expected to be quoted.
    ivankalitaonefootball committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    8533e76 View commit details
    Browse the repository at this point in the history