infinite loop concurrency bug

gitleaks · Oct 29, 2021 · 9487daa · 9487daa
1 parent 1ee22f3
commit 9487daa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/gitdiff/parser.go b/gitdiff/parser.go
@@ -27,11 +27,12 @@ func Parse(r io.Reader) (<-chan *File, error) {
 	}
 
 	go func() {
+		defer close(out)
+
 		ph := &PatchHeader{}
 		for {
 			file, pre, err := p.ParseNextFileHeader()
 			if err != nil {
-				out <- file
 				return
 			}
 
@@ -59,7 +60,6 @@ func Parse(r io.Reader) (<-chan *File, error) {
 			file.PatchHeader = ph
 			out <- file
 		}
-		close(out)
 	}()
 
 	return out, nil