Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty name and/or email are valid use cases. #2

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

k0ral
Copy link

@k0ral k0ral commented Feb 13, 2022

As a matter of fact, git does not fully enforce that name and/or email are non-empty. I don't know how to get there, but as an example, from hantsy/symfony-rest-sample:

commit 6639b2d5316ad1e41a3264199f7a91ba9b13a32d
Author:  <>
Date:   Sun Feb 13 09:17:25 2022 +0000

    Deployed 57b0a9f with MkDocs version: 1.2.3

Thus, I believe go-gitdiff should support this use-case.

@zricethezav
Copy link

@k0ral great addition, thanks!

@zricethezav zricethezav merged commit 566f41b into gitleaks:master Feb 19, 2022
zricethezav pushed a commit that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants