Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Collapse help using accordeon #35

Closed
pravdomil opened this issue Jun 23, 2023 · 15 comments
Closed

[FEATURE REQUEST] Collapse help using accordeon #35

pravdomil opened this issue Jun 23, 2023 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@pravdomil
Copy link
Contributor

image
@pravdomil pravdomil added the enhancement New feature or request label Jun 23, 2023
@gitmylo
Copy link
Owner

gitmylo commented Jun 23, 2023

i wish i could, but accordions don't work very well, maybe i can somehow do it with css.

@pravdomil
Copy link
Contributor Author

why they dont work?

@pravdomil
Copy link
Contributor Author

you can use <details><summary> then

@gitmylo
Copy link
Owner

gitmylo commented Jun 23, 2023

you can't set visible on an accordion, sadly. but maybe i can set el-classes or whatever it's called

@gitmylo gitmylo self-assigned this Jun 23, 2023
@gitmylo
Copy link
Owner

gitmylo commented Jun 23, 2023

you cannot set elem-classes on textboxes though, so that won't work either

@pravdomil
Copy link
Contributor Author

pravdomil commented Jun 23, 2023

this looks clean
image

under text area put

Split your long form generations with newlines (enter), every line will be generated individually, but as a continuation of the last. Empty lines at the start and end will be skipped.

and under file upload put

Clear spoken, no noise, no music. Ends after a short pause for best results.
When cloning a voice:
- The speaker will be saved in the data/bark_custom_speakers directory.
- The “file” output contains a different speaker. This is for saving speakers created through random generation. Or continued cloning.

@gitmylo
Copy link
Owner

gitmylo commented Jun 23, 2023

i got the accordion working, maybe it was fixed in a gradio update?

gitmylo added a commit that referenced this issue Jun 23, 2023
@pravdomil
Copy link
Contributor Author

well maybe is better to put the instructions where they belong next to inputs

gitmylo added a commit that referenced this issue Jun 23, 2023
@pravdomil
Copy link
Contributor Author

and what is this?

2396a45

image

@gitmylo
Copy link
Owner

gitmylo commented Jun 23, 2023

and what is this?

2396a45
image

the accordion element has to be sent through to the ui manager so it can be correctly hidden and shown when it becomes relevant or irrelevant.

image

these are all workarounds, because gradio does not support replacing of elements, so you have to hide them somehow, and i'm definitely not going to write down each individual element, so i made that code to manage it.

image

the reason it is not included on the other side, in the inputs, is because the versions after 5aa6e69 skip any elements which aren't inputs.

[Bonus] Here's some screenshots from when i had just implemented the hiding system:

image
image

@pravdomil
Copy link
Contributor Author

ok, now it looks good

@gitmylo gitmylo closed this as completed Jun 23, 2023
@pravdomil
Copy link
Contributor Author

this can be a better design

image

@gitmylo
Copy link
Owner

gitmylo commented Jun 23, 2023

sounds more relevant to #39

@gitmylo
Copy link
Owner

gitmylo commented Jun 23, 2023

also, planning to add a smart split option, but i'll add the hint for now

@pravdomil
Copy link
Contributor Author

I made a new issue to be clear #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants