Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thank you and some clarifications #85

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Thank you and some clarifications #85

wants to merge 9 commits into from

Commits on Feb 22, 2022

  1. Suggested clarifications 

    * first of all, thanks for such a great and thorough explanation.  Easily the most detailed explanation of deploying a create-react-app to Github I found and was the only way I was able to do it successfully.  Thank you so much for providing this.  

Some suggestions that would have helped me: 

* on line 145: add a hard return because otherwise the `gh-page -b master -d build` gets spread over two lines.  When I was going through this I didn't noticed it and only saw the `gh-page -b master -d` and tried to build it with that and it kept not working.  Eventually got it working after re-reading the docs a number of times. 

* on line 173: added a paragraph and image to help people see where to find the project name. 

* on line 46: added a link to Github docs explaining the difference between a user site and a project site.  I sat for a while confused as to which one I should use and the links provided both pointed to the same page, which also didn't have an explanation.
    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    fe1aadb View commit details
    Browse the repository at this point in the history

  2. screenshot

    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    8195648 View commit details
    Browse the repository at this point in the history

  3. Update README.md

    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b3b650b View commit details
    Browse the repository at this point in the history

  4. Delete screenshot-github.com-2022.02.22-06_58_50.png 

    wrong screenshot
    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    3c3dd20 View commit details
    Browse the repository at this point in the history

  5. Add files via upload

    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    4615117 View commit details
    Browse the repository at this point in the history

  6. Update README.md 

    update w/ correct screenshot
    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    74e7c6c View commit details
    Browse the repository at this point in the history

  7. Update README.md

    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b9bd531 View commit details
    Browse the repository at this point in the history

  8. Update README.md

    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    93b3172 View commit details
    Browse the repository at this point in the history

  9. Update README.md 

    * line 125: when I was going through the explanation I wasn't sure if I was supposed to add the "+" sign or not.  I knew in commit histories that I had seen it before, but wasn't sure what the explanation here was wanting me to do.  I ended up trying both before I figured out what the docs were trying to say.
    @trrapp12
    trrapp12 committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2e04a93 View commit details
    Browse the repository at this point in the history