-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images not showing in offline mode #96
Comments
Hi @jerdog can you please point me at your presentation repo so I can try reproduce and investigate the issue you have reported. Thanks. |
Ok, so I just took your sample presentation offline. Based on the You can see both are shown Given this, I do not appear to be able to reproduce the problem you have reported here. So a few further questions for you:
|
@jerdog as a side note, the size of your second image is not a perfect fit for the slideshow aspect ratio so you might want to consider using the Image Sizing and Scaling feature to have that rendered more nicely on the slide. For example, replace your original markdown:
With this:
Not required of course, but it may render more nicely for you when you are using a tall-and-narrow image to fill a wide-and-short slide as in this case. |
I am using the python 3 http.server - what about you? And yeah - was planning on making that image a slide image |
My testing has been on OSX. I have tried both Python 2.7.x and Python 3 HTTP servers using:
and
respectively. In both cases, both of your images were rendered without any problems. |
@jerdog if you haven't already you might want to verify that the image assets are available on disk as the expected location and loadable by your HTTP server. The expected URLs are as follows:
Both of these URLs should open and display the respective images in your browser. And if they don't, we have new clues to investigate. |
Yeah - they open with direct links - but they don't open in offline gitpitch for me. When you look at the code output, it is showing the following locations: |
@jerdog can you put the Also, can you please try download the bundle again and verify that the latest bundle is also exhibiting the problems you described. I asked for this having noted above that the offline bundle I have tested here has worked perfectly. |
So I feel stupid... Just removed my local and recreated it from the offline and now it works. No idea what happened/changed/etc. Thanks for your patience. My guess is it had something to do with multiple changes made to my presentation/code between when I downloaded the original offline copy and when I was just attempting to copy in my changed PITCHME.md file |
No problem @jerdog just glad to hear you are back up and running with your GitPitch presentation. If you have any further questions don't be afraid to get in touch. |
Hello i've encountered the same problem and find out why. |
@dbuteau this issue thread is for an old offline feature that is no longer supported. I know you are using GitPitch Desktop. To set a custom port for the Desktop you need to make two changes on your launch command:
For example:
See the Desktop FAQ for details. The documented steps should solve your problem. Let me know how it goes. Cheers, David. |
When I add an image to a slide, I am using:
![Logo](images/opensource_logo.png)
Which works when viewing online. But when I download and attempt to view it locally
python -m http.server
It displays the alt-text (in this case "Logo") instead of the image. It's trying to pull it from
http://localhost:8000/assets/opensource_logo.png
which in the offline.zip is relative to the pitchme.md file in the /md/assets/ folder and the file is there... All very strangeThe text was updated successfully, but these errors were encountered: