Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sagor999 committed Apr 29, 2022
1 parent 57d3dc7 commit 1a330fe
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions components/gitpod-db/README.md
Expand Up @@ -2,6 +2,9 @@

Contains all the database related functionality, implemented using [typeorm](https://typeorm.io/).

### Working on gitpod-protocol component
When you are making changes to gitpod-protocol component, make sure to run `yarn build` in gitpod-protocol folder to make sure your changes will be rebuild. Also consider running `yarn watch` so that any changes are rebuilt in realtime.

### Adding a new table
1. Create a [migration](./src/typeorm/migration/README.md) - use the [baseline](./src/typeorm/migration/1592203031938-Baseline.ts) as an exemplar
1. Create a new entity that implements the requisite interface or extend an existing entity as required - see [db-user.ts](./src/typeorm/entity/db-user.ts)
Expand Down
2 changes: 1 addition & 1 deletion components/gitpod-db/src/typeorm/workspace-db-impl.ts
Expand Up @@ -713,7 +713,7 @@ export abstract class AbstractTypeORMWorkspaceDBImpl implements WorkspaceDB {

public async storeVolumeSnapshot(volumeSnapshot: VolumeSnapshot): Promise<VolumeSnapshot> {
const volumeSnapshots = await this.getVolumeSnapshotRepo();
const dbVolumeSnapshot = volumeSnapshots as DBVolumeSnapshot;
const dbVolumeSnapshot = volumeSnapshot as DBVolumeSnapshot;
return await volumeSnapshots.save(dbVolumeSnapshot);
}

Expand Down

0 comments on commit 1a330fe

Please sign in to comment.