Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] nil deref in parseInstanceConfigs #3007

Closed
markfirmware opened this issue Jan 25, 2021 · 2 comments · Fixed by #3044
Closed

[supervisor] nil deref in parseInstanceConfigs #3007

markfirmware opened this issue Jan 25, 2021 · 2 comments · Fixed by #3044
Labels
component: supervisor type: bug Something isn't working
Milestone

Comments

@markfirmware
Copy link

Will not start. I captured a download and recovered my pending changes. I will leave this workspace alone for you to inspect if you wish. Let me know if you do not need it.

@csweichel csweichel added the type: needs triage We've seen the issue but need to investigate to decide what type of issue it is label Jan 25, 2021
@geropl geropl self-assigned this Jan 25, 2021
@geropl geropl added the type: bug Something isn't working label Jan 25, 2021
@geropl
Copy link
Member

geropl commented Jan 25, 2021

So, this was a fun dive. But it yielded a nil deref in the end:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xa4ce27]

goroutine 99 [running]:
github.com/gitpod-io/gitpod/supervisor/pkg/ports.parseInstanceConfigs(0xc00000e0c0, 0x1, 0x1, 0xc0007b0480, 0xc00064a988, 0xc0000aff20, 0xc00064aa38)
	/tmp/build/components-supervisor--app.ab31968bf49cbf8ddfd44ce3fd31fb8dffa29d82/_deps/gitpod-core-components-supervisor--app/pkg/ports/ports-config.go:184 +0xa7
github.com/gitpod-io/gitpod/supervisor/pkg/ports.(*ConfigService).update(0xc0003824e0, 0xc0001823f0, 0xc0000afee8, 0x2)
	/tmp/build/components-supervisor--app.ab31968bf49cbf8ddfd44ce3fd31fb8dffa29d82/_deps/gitpod-core-components-supervisor--app/pkg/ports/ports-config.go:159 +0x7d
github.com/gitpod-io/gitpod/supervisor/pkg/ports.(*ConfigService).Observe.func1(0xc0005340c0, 0xc000600120, 0xc0003824e0, 0xdbea20, 0xc000520000)
	/tmp/build/components-supervisor--app.ab31968bf49cbf8ddfd44ce3fd31fb8dffa29d82/_deps/gitpod-core-components-supervisor--app/pkg/ports/ports-config.go:138 +0x2f2
created by github.com/gitpod-io/gitpod/supervisor/pkg/ports.(*ConfigService).Observe
	/tmp/build/components-supervisor--app.ab31968bf49cbf8ddfd44ce3fd31fb8dffa29d82/_deps/gitpod-core-components-supervisor--app/pkg/ports/ports-config.go:112 +0xac

Thx @markfirmware for reporting!

@geropl geropl added component: supervisor and removed type: needs triage We've seen the issue but need to investigate to decide what type of issue it is labels Jan 25, 2021
@geropl
Copy link
Member

geropl commented Jan 25, 2021

/cc @csweichel added to feb milestone. Could also go into Jan if there is some space?

@geropl geropl changed the title ab1ab01b-e8e8-41ed-8ac1-611927f2d283 is stuck in red [supervisor] nil deref in parseInstanceConfigs Jan 25, 2021
@geropl geropl removed their assignment Jan 25, 2021
@geropl geropl added this to the February 2021 milestone Jan 25, 2021
csweichel pushed a commit that referenced this issue Jan 28, 2021
@csweichel csweichel modified the milestones: February 2021, January 2021 Jan 28, 2021
csweichel pushed a commit that referenced this issue Jan 28, 2021
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this issue Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: supervisor type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants