Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] rewrite configuration to use a single config source #4650

Closed
AlexTugarev opened this issue Jun 29, 2021 · 3 comments · Fixed by #4882, #4982 or #5496
Closed

[server] rewrite configuration to use a single config source #4650

AlexTugarev opened this issue Jun 29, 2021 · 3 comments · Fixed by #4882, #4982 or #5496
Assignees
Labels
component: server team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@AlexTugarev
Copy link
Member

currently the server component's config consists of a number of env vars (which might be rendered from secrets) and mounts.

as suggested by @csweichel, it would be best to rewrite the configuration of the server component (perhaps payment as well, as they share some of the configuration,) to use a single source. advantages expected by this change are:

  • make telepresence easier
  • reduce turnarounds when working on changes related to payment or github
@AlexTugarev AlexTugarev added component: server type: improvement Improves an existing feature or existing code labels Jun 29, 2021
@csweichel csweichel moved this from Inbox to Scheduled in [DEPRECATED] Product Engineering Groundwork Jul 2, 2021
@geropl geropl self-assigned this Jul 15, 2021
@geropl geropl moved this from Scheduled (limit: 25 WIP) to In Progress in [DEPRECATED] Product Engineering Groundwork Jul 15, 2021
@geropl geropl moved this from In Progress to In Review in [DEPRECATED] Product Engineering Groundwork Jul 26, 2021
@geropl
Copy link
Member

geropl commented Jul 27, 2021

It turns out the helm chart and parsing interaction in Env is rather complicated. To make sure we do not miss any variance we take a 2 step approach:

  1. Introduce new Config shape which contains everything from Env (minus some basic refactoring and cleanup). This is not used yet to make sure we don't break anything, but instead just printed out on startup for reference.
  2. The next step is to ease the process of serializing->deserializing the config from

@geropl
Copy link
Member

geropl commented Jul 27, 2021

Re-opening as #4882 was only the 1st of 2 PRs.

@geropl geropl reopened this Jul 27, 2021
@roboquat roboquat moved this from In Review to In Progress in [DEPRECATED] Product Engineering Groundwork Jul 27, 2021
@JanKoehnlein JanKoehnlein added the team: webapp Issue belongs to the WebApp team label Aug 24, 2021
@geropl
Copy link
Member

geropl commented Sep 2, 2021

While a biggest chunk has been merged, there are still some ToDos left:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: server team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
No open projects
4 participants