Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Remove legacy configuration #5496

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 2, 2021

Fixes #4650.

Validate changes

  1. see that server starts
  2. search for process.env in components/**/*.ts and verify that all places left are independent of the changes made here
  3. compare old and new config
  • copy config from logs as new.json
  • create another branch from main, wait until the preview env is deployed, and copy the field "new config" from the logs and save as old.json
  • clean both files with 'replace \n -> \n' and 'replace \" -> "' followed by cat new.json | jq -S > new resp.
  • compare new and old
    • note that all changes are because of either:
    • different output format
    • additions because we now print logs unfiltered

@geropl geropl marked this pull request as ready for review September 6, 2021 07:51
@geropl
Copy link
Member Author

geropl commented Sep 6, 2021

@laushinka @jankeromnes It would be awesome if one of you found time to review this until tomorrow morning. This is quite likely to create conflicts (again).

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat
Copy link
Contributor

roboquat commented Sep 6, 2021

LGTM label has been added.

Git tree hash: 1d69e6ebf55c254addc854595781def2edca17a7

@roboquat
Copy link
Contributor

roboquat commented Sep 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svenefftinge

Associated issue: #4650

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 267448b into main Sep 6, 2021
@roboquat roboquat deleted the gpl/server-config-cleanup branch September 6, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[server] rewrite configuration to use a single config source
3 participants