Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of team members don't match on the billing #4693

Closed
alesanchezr opened this issue Jul 2, 2021 · 10 comments · Fixed by #4713
Closed

Number of team members don't match on the billing #4693

alesanchezr opened this issue Jul 2, 2021 · 10 comments · Fixed by #4713
Assignees
Labels
priority: highest (user impact) Directly user impacting type: bug Something isn't working

Comments

@alesanchezr
Copy link

Bug description

When I go to the team settings it says that we have 322 members but we deleted (disabled) some of them and the number should be 192 instead.

I'm afraid the billing will also match the 322 instead of 192.

Teams-—-Gitpod

Steps to reproduce

  1. go to team settings
  2. Open the team details
  3. count the number of items on the list

Expected behavior

The number of team members should match the number of items in the list.

Example repository

No response

Anything else?

No response

@alesanchezr alesanchezr changed the title Number of team members don't match Number of team members don't match on the billing Jul 2, 2021
@jankeromnes jankeromnes added priority: highest (user impact) Directly user impacting type: bug Something isn't working labels Jul 6, 2021
@jankeromnes
Copy link
Contributor

Hi @alesanchezr! Thank you for reporting this problem. I can confirm that something is not right with your Team Plan. We'll investigate why there is such a discrepancy; fix any underlying bug; and of course refund any undue charges.

@csweichel csweichel added this to Inbox in [DEPRECATED] Product Engineering Groundwork via automation Jul 6, 2021
@csweichel csweichel moved this from Inbox to Scheduled (limit: 25 WIP) in [DEPRECATED] Product Engineering Groundwork Jul 6, 2021
@lechien73
Copy link

Hi @jankeromnes - sorry to pile on, but this made me check our Team Unleashed plan too.

We are showing 1649 members, but I scraped the content of the Manage Team modal and ran it through a script, which shows a count of 1336. I've spot checked at different places to ensure that the data is the same as the Manage Team modal, and all seems to be correct.

Could you add this to your check too, please? The account email is: gitpodteam@codeinstitute.net.

Thanks

@jankeromnes
Copy link
Contributor

Hi @lechien73, thank you for double-checking your team account, which seems to be affected as well.

We're hoping to fix this problem for every (potentially affected) team account today or tomorrow, with the fix going to production shortly thereafter. Will post updates to this issue.

@jankeromnes jankeromnes moved this from Scheduled (limit: 25 WIP) to In Progress in [DEPRECATED] Product Engineering Groundwork Jul 6, 2021
@jankeromnes jankeromnes self-assigned this Jul 6, 2021
@lechien73
Copy link

@alesanchezr - I don't know if this is helpful to you, but I've made a Chrome extension that helps manage our teams as they get bigger. It's awaiting review in the extension store at the moment, but you can sideload it from here: https://github.com/lechien73/GitpodTeamHelper

It adds some UI elements so you can see how many active and inactive users you have, and highlights the inactive users so they're easier to find when you are scrolling.

@jankeromnes
Copy link
Contributor

jankeromnes commented Jul 7, 2021

Wow, cool, thanks for sharing this extension @lechien73! (This also clearly shows the limitations of our current Teams UI... 🙈)

By the way, you may be interested in knowing that we're revamping Teams in Gitpod. This is not ready yet, but parts of it are already implemented behind a feature flag (we could potentially enable it for you, if you'd like to have a look). See the design specs for Teams and Member management in #4421 -- the plan is to roll out the new Teams UI first (independently of the current Teams, which will remain unchanged / unaffected) and then, when it works well, to re-implement a better Teams billing system and provide a smooth migration path for existing Teams (I'd say this might happen in a few months from now, and I can keep you in the loop).


Additionally, I've implemented a fix for the current Teams billing issue: #4713

Unfortunately, I can't test it right now (I couldn't get a testing environment with payments enabled), and I'll be off for the rest of the week. @geropl and/or @AlexTugarev, could you please take a look at my Pull Request, and see if you can test it? If it looks correct to you and works as expected, please merge it so that it can be deployed next week.

@jankeromnes jankeromnes assigned AlexTugarev and geropl and unassigned jankeromnes Jul 7, 2021
@lechien73
Copy link

@jankeromnes - yes please, I'd like that. When I was perusing the code for Teams, I thought I found stuff there that isn't used yet. With such a large (and growing) team, anything that makes it easier for our Student Care folks to manage is a real gift.

PS: I packaged the extension and it's now in the Chrome Web Store at this link.

[DEPRECATED] Product Engineering Groundwork automation moved this from In Progress to Awaiting Deployment Jul 9, 2021
@geropl
Copy link
Member

geropl commented Jul 9, 2021

Was auto-closed with the PR. Re-opening as there is still some stuff to sort-out, mainly re-funding for wrong invoices!

@geropl geropl reopened this Jul 9, 2021
@jankeromnes jankeromnes self-assigned this Jul 13, 2021
@jankeromnes
Copy link
Contributor

The fix is now deployed to production:

  • The number of seats displayed in the overview of https://gitpod.io/teams should always match the number of seats visible in the Manage Members modal (e.g. "5 Members" / 5 seats -- note: the count includes deactivated seats)

  • Performing at least one seat operation (adding a seat, deactivating a seat, reactivating a seat) should fix / correctly set the quantity visible in Billing (e.g. "Team Professional (EUR) x 4" -- note: this excludes deactivated seats, because they won't be part of your next bill)

  • We are now backprocessing data in order to identify all affected team plans and issue refunds

Thanks again for reporting this embarrassing bug and for bearing with us through the fix! 🙏


And on a side note, if you'd like to play with our new (experimental, not-ready-yet) Teams & Projects UI, please ping me and I'll enable the flag for your account. (Same process for leaving the experiment again and waiting for it to be ready.) As a reminder, the new Teams UI is totally decoupled from the current Team Plans -- i.e. you'll need to manage both independently, and you can't cause side effects from one to the other. @lechien73 I'll enable this on your account since you asked. 🙂

@alesanchezr
Copy link
Author

@lechien73 your extension is amazing, thanks for that!! I'm building a Gtipod/VSCode Extension for practicing code if you want to try it. We are in the process of migrating from Theia to VSCode but you can try it already if you open it with Theia, here is a sample: https://github.com/breatheco-de/python-flask-api-tutorial

@jankeromnes Thank you! We don't mind bugs like this when such a great team and product is always there for us. 😄

@csweichel csweichel removed this from Awaiting Deployment in [DEPRECATED] Product Engineering Groundwork Jul 16, 2021
@jankeromnes
Copy link
Contributor

The fix was deployed on July 13th and we've successfully issued refunds where applicable, so this issue can now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: highest (user impact) Directly user impacting type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants