Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or adjust Prebuild status in the Prebuild page header (now duplicates the bottom status) #5526

Closed
jankeromnes opened this issue Sep 3, 2021 · 0 comments · Fixed by #5730
Assignees
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. roadmap item: teams & projects type: improvement Improves an existing feature or existing code

Comments

@jankeromnes
Copy link
Contributor

Follow-up to #5474:

#5474 (comment)

question: Now that we have proper status updates down here and this component is used as is in the project configurator, wondering if it makes sense to change or remove the status from the header although it could be useful to have the status up there.

If we remove the header instance we'll have to make sure the bottom part of the prebuild output is always visible. Of course, we could leave it as is for now but make sure the designs for both is identical. Alternatively, we could only include the status icon to avoid having duplicated information. What do you think?

BEFORE AFTER (A) AFTER (B)
BEFORE AFTER (A) AFTER (B)

Also, the top status is based on the prebuild (PrebuiltWorkspaceState), while the bottom status is based on the instance (WorkspaceInstancePhase).

Normally, the two should always be in sync, but it can happen that they disagree (e.g. because of incidents or bugs), which can be very confusing and looks bad:

#5474 (comment)

issue: Noticed that the status on the header section does not automatically get updated but you need to reload to the get new status. This could lead to having a discrepancy between these two places where status is surfaced.

Example A Example B
Frame 218 Frame 2182

Thus, having only one status in this page makes even more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. roadmap item: teams & projects type: improvement Improves an existing feature or existing code
Projects
No open projects
Status: Low hanging fruits 🍒
Development

Successfully merging a pull request may close this issue.

2 participants