Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect users to the members list when trying to join a team they have already joined #5925

Closed
gtsiolis opened this issue Sep 29, 2021 · 2 comments · Fixed by #5960
Closed

Redirect users to the members list when trying to join a team they have already joined #5925

gtsiolis opened this issue Sep 29, 2021 · 2 comments · Fixed by #5960
Assignees
@AlexTugarev
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
[DEPRECATED] Product Engineering Grou...

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

When a user is trying to join a team you've already joined they see the following error page.

Redirect users to the members list when trying to join a team they have already joined

See also relevant discussion (internal). Cc @AlexTugarev

This was also brought up while adding this in #4490 (comment). Cc @jankeromnes

Joining a team you've already joined
gitpod io_teams_join_inviteId=f2c69638-1d9b-483e-bad0-61a0e81204a8

Proposal

Cross-posting from the relevant discussion (internal):

Ideally, this would also include some feedback to the user using a toast component (see #3530).

However, redirecting to the team or members list sounds like a good MVC.
@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team labels Sep 29, 2021
@gtsiolis gtsiolis added this to Inbox in [DEPRECATED] Product Engineering Groundwork via automation Sep 29, 2021
@gtsiolis gtsiolis mentioned this issue Sep 29, 2021
Merged
@JanKoehnlein
Copy link
Contributor

/schedule

@roboquat roboquat moved this from Inbox to Scheduled in [DEPRECATED] Product Engineering Groundwork Sep 30, 2021
@roboquat
Copy link
Contributor

@JanKoehnlein: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlexTugarev AlexTugarev self-assigned this Sep 30, 2021
@AlexTugarev AlexTugarev moved this from Scheduled to In Progress in [DEPRECATED] Product Engineering Groundwork Sep 30, 2021
@AlexTugarev AlexTugarev mentioned this issue Sep 30, 2021
Merged
@AlexTugarev AlexTugarev moved this from In Progress to In Review in [DEPRECATED] Product Engineering Groundwork Sep 30, 2021
@gtsiolis gtsiolis moved this from In Review to Awaiting Deployment in [DEPRECATED] Product Engineering Groundwork Oct 1, 2021
@JanKoehnlein JanKoehnlein moved this from Awaiting Deployment to Deployed in [DEPRECATED] Product Engineering Groundwork Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexTugarev AlexTugarev

Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
No open projects
[DEPRECATED] Product Engineering Grou...
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[teams] don't show error if already in team gitpod-io/gitpod
4 participants
@gtsiolis @JanKoehnlein @AlexTugarev @roboquat