Clean up member-less teams

[gtsiolis]

Bug description

While we now delete teams from the database when a user deletes a team (see #6273) we still have not resolved what happens to teams when the last team owner member tries to leave the team (see #4623).

This causes some confusion as users can not reuse a team name after leaving a team as the last team member, see #6273 (comment).

Some of these teams also surface on the team scope selector.

We should probably resolve #4623 first and then clean up the the database and remove member-less teams. 🗺️

Steps to reproduce

1. Create a team
2. Go to team members
3. Leave the team
4. Try creating a new team with the same name

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

[jldec]

/schedule

[roboquat]

@jldec: Issue scheduled in the meta team (WIP: 0)

In response to this:

/schedule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[laushinka]

Apparently if an owner is the last one remaining and switches to a member role, then they are able to leave the team. Maybe we should not allow an owner to switch role as a member, when they are the last one remaining. The intention does not make sense either. I am not sure though how often this happens, or if it happens at all. Context[1]

[gtsiolis]

Maybe we should not allow an owner to switch role as a member, when they are the last one remaining.

It makes sense to never allow users to change their own role in a team regardless if they are the last remaining member, right?

[laushinka]

It makes sense to never allow users to change their own role in a team regardless if they are the last remaining member, right?

Hmm, I'm trying to think of cases but can't think of any, but maybe there would be some legitimate uses of this. Maybe @jldec has some thoughts wrt customer support.

[jldec]

It's reasonable for an owner to reduce their role to member, after they delegate ownership to someone else.
It's a problem if this leaves the team without any owners.
Since this is unlikely we're not going to work on this a.t.m.

[gtsiolis]

It's reasonable for an owner to reduce their role to member, after they delegate ownership to someone else.

thought: Not sure if this is a common flow though. In such cases, usually, users are removed from a team following a process or they manually leave a team to clean up non-longer relevant information and teams. 💭

issue: Besides this, the cost of allowing users to lower their permissions keeps two issue around: a) orphaned teams without owners and b) empty teams as the last member can leave a team although we do not allow this for owners, see screenshot below.

issue: Also, this issue was originally created at the early days of teams and projects which has led to having empty and non-accessible teams listed in the team scope selector. Here's what I see on production for my account, see screenshot below. However, this could be individually resolved for users by introducing a way to delete teams from the admin dashboard, see #8523.

Last owner trying to leave a team	Member-less teams

suggestion: I agree this is an edge case and fixing this would have a low impact as the issue affects a very small fraction of users. Disallowing team owners to change their role to member could help avoid introducing more member-less teams or confusion.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gtsiolis]

Closing, as this rendering issue in the team scope selector is not reproducible anymore.

However, there's a closely related and follow-up issue in #10166. Cc @jldec

[nidh-eesh]

@gtsiolis This problem still persists as I have ran into it today. Created a team, demoted myself to member accidentally, left the team hoping it would get deleted(I was the only member). And now locked out of using the team name as error outputs "Team name already in use".

[jldec]

@nidhinmanu - please see discord

The dashboard should have prevented this scenario by preventing self-removal from team of last team owner. Unfortunately you discovered a "loophole" by changing your role from owner to member.

[gtsiolis]

Thanks for noticing, @nidhinmanu! Cc @jldec

FWIW, I've opened a new issue in #11452 for this specific bug, as this has been brought up a couple of times in the past.