Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Installer]: In-cluster docker registry doesn't support non-default namespace #6728

Closed
mrsimonemms opened this issue Nov 16, 2021 · 0 comments · Fixed by #7107
Closed

[Installer]: In-cluster docker registry doesn't support non-default namespace #6728

mrsimonemms opened this issue Nov 16, 2021 · 0 comments · Fixed by #7107
Labels
component: install Terraform installation scripts, helm charts, installer images

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Nov 16, 2021

Bug description

In the templates in /installer/third_party/charts/docker-registry, the downloaded charts in docker-registry-1.11.0.tgz don't specify the metadata.namespace: {{ .Release.Namespace }} property. This means that the generated charts won't get installed to the same namespace if the namespace is not default

Steps to reproduce

Run gitpod-installer render -c /path/to/config --namespace custom-nsp and search for the docker-registry components

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

This can be fixed in the following ways:

  1. Import the files from the chart rather than using them as a Helm dependency. This is simpler, but has the added risk of this change being forgotten if we ever update the dependency
  2. post-process the generated YAML in installer/pkg/components/docker-registry/helm.go. It's potentially a dirtier solution, but means we can still use the third party dependency
  3. apply fix to dependency
@mrsimonemms mrsimonemms added the component: install Terraform installation scripts, helm charts, installer images label Nov 16, 2021
@mrsimonemms mrsimonemms changed the title Installer in-cluster docker registry doesn't support non-default namespace [Installer]: In-cluster docker registry doesn't support non-default namespace Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: install Terraform installation scripts, helm charts, installer images
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant