Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: update docker-registry to allow for pod security policy application #7107

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Dec 7, 2021

Description

Updates the in-cluster Docker registry to latest version. This brings in two PRs important to us:

  • 42 - deploy registry to a specific namespace
  • 44 - create/use a service account for the deployment

This also creates a service account for the Docker registry and grants it the relevant pod security policies

Related Issue(s)

Fixes #6728
Fixes #7139

How to test

Deploy a self-hosted instance with in-cluster container registry selected

Release Notes

[installer]: update docker-registry to allow for pod security policy application

Documentation

@mrsimonemms mrsimonemms changed the title docker-registry - dependent upon external PR [installer]: update docker-registry to allow for pod security policy application Dec 9, 2021
@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Dec 12, 2021

/werft run

👍 started the job as gitpod-build-sje-installer-docker-reg-pr.2

@mrsimonemms mrsimonemms marked this pull request as ready for review December 12, 2021 11:38
@mrsimonemms mrsimonemms requested a review from a team December 12, 2021 11:42
@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #7107 (3436c9b) into main (c27d245) will decrease coverage by 1.67%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #7107      +/-   ##
========================================
- Coverage   7.44%   5.76%   -1.68%     
========================================
  Files         15      13       -2     
  Lines       1330    1162     -168     
========================================
- Hits          99      67      -32     
+ Misses      1228    1094     -134     
+ Partials       3       1       -2     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27d245...3436c9b. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Dec 12, 2021

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: e6a866faf2c0fcd6f76d26dc8528fe8e6adc2f75

@roboquat roboquat added the lgtm label Dec 12, 2021
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #6728

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit de31383 into main Dec 12, 2021
@roboquat roboquat deleted the sje/installer-docker-reg-pr branch December 12, 2021 11:47
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
3 participants