Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist github profiles for prof open-source #8212

Closed
ghuntley opened this issue Feb 15, 2022 · 1 comment
Closed

whitelist github profiles for prof open-source #8212

ghuntley opened this issue Feb 15, 2022 · 1 comment
Assignees
Labels
team: webapp Issue belongs to the WebApp team

Comments

@ghuntley
Copy link
Contributor

ghuntley commented Feb 15, 2022

overview

@ghuntley The "input format" now would be a list of GitHub profile names a la:

github.com/geropl
github.com/ghuntley
....

That we turn into an INSERT (manually for now) and execute that against the DB.

The change did not land today, sadly, but I'm inclined to deploy it tomorrow morning (if there's no strong votum against it, and there's enough motivation to do so). Thursday at latest, that's our next regular deployment.

If you share the list of handles I can also insert them after deployment. 👍

request

Here is the list of handles (internal link). Can you please insert them? See orange column :)

related issues

@ghuntley ghuntley added the team: webapp Issue belongs to the WebApp team label Feb 15, 2022
@gitpod-io gitpod-io locked and limited conversation to collaborators Feb 16, 2022
@geropl
Copy link
Member

geropl commented Feb 16, 2022

Steps I did:

  • filter out all entries containing @
  • prefixed all entries with github.com/

Ran them with a query of the form:

INSERT INTO d_b_oss_allow_list
	(identity)
    VALUES
(github.com/...),
(github.com/...),
...
;

Started with a handful of entries including a test account of mine: worked as expected:
image

@geropl geropl closed this as completed Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Development

No branches or pull requests

2 participants