Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to record backup/restore success/failure count #10342

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Add metrics to record backup/restore success/failure count #10342

merged 1 commit into from
Jun 6, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented May 30, 2022 •
edited

Description

Add metrics to record workspace backup/restore success/failure count.

Related Issue(s)

Fixes #10330

How to test

  • Launch a new workspace with the preview env.
  • Create a new workspace, create a large file in the workspace and stop the workspace. 
    dd if=/dev/urandom of=1G.random bs=16M count=64
  • Port forward metrics port of the ws-manager and look for new metrics. 
    kubectl port-forward <ws-manager-pod-name> 9500:9500
curl -XGET localhost:9500/metrics
  • The reported count should be correct.
    • workspace_backups_success_total
    • workspace_backups_failure_total
    • workspace_restores_success_total
    • workspace_restores_failure_total

Release Notes

[ws-manager] Add metrics to record backup success/failure count

Documentation

N/A

@jenting jenting force-pushed the jenting/ws-manager-observe-when-10330 branch 9 times, most recently from 6e5e5d0 to 396fa6e Compare June 6, 2022 02:24
@jenting
Add metrics to record backup success/failure count
3787b9b 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting force-pushed the jenting/ws-manager-observe-when-10330 branch from 396fa6e to 3787b9b Compare June 6, 2022 08:09
@jenting jenting marked this pull request as ready for review June 6, 2022 09:10
@jenting jenting requested a review from a team June 6, 2022 09:10
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 6, 2022
@jenting jenting changed the title Add metrics to record backup success/failure count Add metrics to record backup/restore success/failure count Jun 6, 2022
@roboquat roboquat merged commit 609d9b3 into main Jun 6, 2022
@roboquat roboquat deleted the jenting/ws-manager-observe-when-10330 branch June 6, 2022 18:00
@jenting jenting linked an issue Jun 13, 2022 that may be closed by this pull request
observability: add metrics so we can measure frequency and duration of PVC snapshot backup and restore #10195
Closed
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/M team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
3 participants
@jenting @sagor999 @roboquat