content-service: ignore the error of user.overlay.(impure|origin) attributes

[utam0k]

Description

user.overlay.(impure|origin) attributes is a marker to match inodes for overlayfs, such as when an upper layer copies a lower layer file in overlayfs.
However, when restoring content, the container in the workspace is not always running, so there is no problem ignoring the failure.
https://github.com/hisilicon/overlayfs-progs/blob/e10ef686570d9c7eff42f52461593a5c15da56bd/README#L62

Related Issue(s)

Fixes #10108

How to test

No errors including logs with the following steps

1. Open https://to-impure-dir.preview.gitpod-dev.com/#https://github.com/utam0k/gitpod-playground/tree/prebuild-docker
2. Stop the workspace when opening the workspace is completely
3. Reopen the workspace

Release Notes

content-service: Ignore errors in attributes settings

Documentation

No

[aledbf]

@utam0k can we confirm dockerd/containerd is not running when we create the backup?

[utam0k]

@utam0k can we confirm dockerd/containerd is not running when we create the backup?

This issue was also reproduced by simply pulling the image.

[utam0k]

@aledbf I had a suspicion that the container process was running, but is there a problem with the daemon itself?

[aledbf]

@aledbf I had a suspicion that the container process was running, but is there a problem with the daemon itself?

The daemon should not be running when we create the tar file. Maybe we are including temporal files if that's the case?

[utam0k]

@aledbf Sorry, but what did temporal files point out?
This is the error when I pull with docker and docker-compose with this repository and restart
https://github.com/utam0k/gitpod-playground/tree/prebuild-docker-compose
https://cloudlogging.app.goo.gl/3HRd2Pi9PEtTfW6d8

[aledbf]

@utam0k what about

for key, value := range xattrs {
	// do not set trusted attributes
	if strings.HasPrefix(key, "trusted.") {
		continue
	}

	// This is a marker to match inodes, such as when an upper layer copies a lower layer file in overlayfs.
	// However, when restoring a content, the container in the workspace is not always running, so there is no problem ignoring the failure.
	if strings.HasSuffix(key, ".overlay.impure") || strings.HasSuffix(key, ".overlay.origin") {
		continue
	}

	if err := unix.Lsetxattr(name, key, []byte(value), 0); err != nil {
		if err == syscall.ENOTSUP || err == syscall.EPERM {
			continue
		}

		log.WithField("name", key).WithField("value", value).WithField("file", name).WithError(err).Warn("restoring extended attributes")
		return err
	}
}

[utam0k]

@aledbf Thanks for your good review! PTAL