[loadgen] Support workspace classes #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylos101
reviewed
Jun 1, 2022
Furisto
force-pushed
the
fo/loadgen-classes
branch
from
c3f0c08
to
c911d58
Compare
kylos101
reviewed
Jun 1, 2022
kylos101
reviewed
Jun 1, 2022
| @@ -112,7 +117,7 @@ type WsmanExecutor struct { | |||
|
|
|||
| // StartWorkspace starts a new workspace | |||
| func (w *WsmanExecutor) StartWorkspace(spec *StartWorkspaceSpec) (callDuration time.Duration, err error) { | |||
| ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second) | |||
| ctx, cancel := context.WithTimeout(context.Background(), 240*time.Second) | |||
There was a problem hiding this comment.
non-blocking:
@aledbf wdyt of this timeout? I assume it matches your expectation, but wanted to double check.
kylos101
reviewed
Jun 1, 2022
dev/loadgen/prod-benchmark.yaml
Outdated
| ideImage: eu.gcr.io/gitpod-core-dev/build/ide/code:commit-ff263e14024f00d0ed78386b4417dfa6bcd4ae2f | ||
| waitForRunning: "600s" | ||
| waitForStopping: "600s" | ||
| successRate: 0.80 | ||
| successRate: 0.95 |
There was a problem hiding this comment.
Honest question, why not 100%?
What does that rationale or use case look like, when it is >= 95, but, < 100?
kylos101
reviewed
Jun 1, 2022
There was a problem hiding this comment.
Hey @Furisto , just the one question, solid work amigo! Good call sharing the Loom video, too.
Furisto
force-pushed
the
fo/loadgen-classes
branch
from
c911d58
to
0e98af8
Compare
|
@kylos101 PTAL |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
None
How to test
You can actually now just read the documentation 馃槈
Release Notes