Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] add config setting that allows to debug workspaces #10410

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented Jun 1, 2022

Description

Sometimes workspace pods just shutdown without a way to debug\inspect them.
This PR adds support for adding an extra finalizer that prevents the pod from disappearing, so it is possible to debug\inspect it.

Related Issue(s)

Fixes #

How to test

Release Notes

none

Documentation

Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a corresponding fixture test would be great though.

/hold

@roboquat roboquat added size/XL and removed size/XS labels Jun 2, 2022
@sagor999
Copy link
Contributor Author

sagor999 commented Jun 2, 2022

/unhold

@roboquat roboquat merged commit 73e4101 into main Jun 3, 2022
@roboquat roboquat deleted the pavel/ws-man-debug branch June 3, 2022 15:54
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XL team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants